Skip to content

Police content lengths when provided. - #123

Merged
Lukasa merged 2 commits into
masterfrom
issue/114
Jan 21, 2016
Merged

Lukasa merged 2 commits into
masterfrom
issue/114

Conversation

@Lukasa

@Lukasa Lukasa commented Jan 21, 2016

Copy link
Copy Markdown
Member

Resolves #114.

/cc @Kriechi @mhils It'd be great if you would confirm that this really is ok for mitmproxy. If you're currently unsure I'd like to err on the side of including this, and we can always add a flag to disable it if it turns out to be problematic.

@mhils

mhils commented Jan 21, 2016

Copy link
Copy Markdown
Member

As indicated before, I'm OK with this. 😃

@Kriechi: this may actually make it easier to implement mitmproxy's max_body_len.

@Kriechi

Kriechi commented Jan 21, 2016

Copy link
Copy Markdown
Member

@mhils right now I'm just receiving data frames and check the total length. Works fine as well.
I think this should be ok as well - merge it and we will see what happens! :shipit:

Lukasa added a commit that referenced this pull request Jan 21, 2016
Police content lengths when provided.
@Lukasa
Lukasa merged commit 7552d5f into master Jan 21, 2016
@Lukasa
Lukasa deleted the issue/114 branch January 21, 2016 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants