This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Repository navigation
Using dict or string to set browser location to any arbitrary location - #33
Merged
Merged
Conversation
Contributor
Author
|
See #30. This solves half the problem. |
This was referenced Mar 8, 2018
Closed
Closed
Collaborator
|
@ahopkins Thanks for the pull request, I will review it today. Sorry for inactivity, I've been on holiday for a few weeks |
Contributor
Author
|
No worries! I'm on a little break myself now. And I'll probably pick back up my project using Eel next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did two things in the PR. Let me know if this makes sense for you.
eel.startto accept arguments either in string or dict fashion.Or
This would open the browser to
https://myhost:8888/page.html.If opting for using the
dictthe defaults for each are as follows:The goal of this was to allow for the browser session to render a page NOT served by the
bottleserver. This is accomplished by allowing the user to specify any arbitrary location. The effect of this is to allow applications to be built using webpack (example, react or vue).However, in order to accomplish this on the frontend, I needed to add a method to the JS.
Therefore, if the browser is to render a page not server by bottle, then the user needs to explicitly call