Skip to content

Change pep command regarding file extensions - #377

Closed
larswijn wants to merge 5 commits into
python-discord:djangofrom
larswijn:django
Closed

larswijn wants to merge 5 commits into
python-discord:djangofrom
larswijn:django

Conversation

@larswijn

@larswijn larswijn commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

The pip command would assume either .txt or .rst, which was not always correct. It now always tries both, and should still error the same way when the pip was not found.

larswijn added 2 commits July 1, 2019 21:55
The pip command would assume either `.txt` or `.rst`, which was not always correct. It now always tries both, and should still error the same way when the pip was not found.
@sco1

sco1 commented Jul 1, 2019 •

Copy link
Copy Markdown
Contributor

The line ending change needs to be reverted, this is impossible to review.

See also: #367

larswijn added 3 commits July 1, 2019 22:40
because apparently the online converter didn't do what I expected it to do
new version has different line endings
@larswijn

larswijn commented Jul 2, 2019

Copy link
Copy Markdown
Contributor Author

Closed due to other pull request having better updated write history

See: #378

@larswijn larswijn closed this Jul 2, 2019
@scragly scragly changed the title Change get_pip command regarding file extensions Change pep command regarding file extensions Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants