Repository navigation
Keep removing Python pre-3.9 code - #218
Conversation
e01b11a to
527949f
Compare
527949f to
36da74b
Compare
1f2f72b to
aaa88ae
Compare
mattip
left a comment
There was a problem hiding this comment.
I actually read the whole thing and only had two nits
| import __builtin__ | ||
| except ImportError: | ||
| import builtins as __builtin__ | ||
| import builtins |
There was a problem hiding this comment.
I think this can be removed?
| try: | ||
| from _thread import allocate_lock | ||
| except ImportError: | ||
| from _dummy_thread import allocate_lock |
There was a problem hiding this comment.
When might this fail? I think _thread is required for Python now.
There was a problem hiding this comment.
Indeed _threadhas always been part of Python 3.
aaa88ae to
d7797c5
Compare
2b0bbe5 to
b594ec7
Compare
190b007 to
95033ea
Compare
95033ea to
fe23206
Compare
|
This may need to be rebased and retested. |
|
Yes, this is still a work in progress. Some changes break CI. I need to apply smaller change sets gradually — after rebasing. |
2240429 to
938ddcd
Compare
938ddcd to
32e1e17
Compare
8c5ba8e to
548326f
Compare
ee3070f to
2de1e2b
Compare
c611bd9 to
c4db10e
Compare
10e1c9f to
959b327
Compare
|
Rebased - painfully 😄 |
|
Now I have to go through the whole thing again. There were only two small nits 7 months ago, too bad it was not handled in a timely manner then. |
|
I'm sorry about it. It was still a draft at the time, it took me quite some time to iron our small issues and make sure all changes are correct. Both suggestions have been taken into account:
|
021215a to
14b5c64
Compare
These are automatic fixes using: * `--select UP036 --fix --unsafe-fixes`
These are manual fixes of testing/conftest.py
These are manual fixes of testing/udir.py
These are manual fixes of testing/embedding/
These are manual fixes of testing/cffi1/
These are manual fixes of testing/cffi0/
These are manual fixes of testing/support.py
These are manual fixes of src/c/test_c.py Co-Authored-By: mattip <matti.picus@gmail.com>
These are manual fixes of src/cffi/ Co-Authored-By: mattip <matti.picus@gmail.com>
These are manual fixes of src/c/ wchar_helper_3.h → wchar_helper.h
14b5c64 to
e063d0f
Compare
|
Rebased. |
|
Thanks |
Companion to #124 and #214.
Apply rule UP036, it implies lots of manual changes and requires extra care.
Needs #214 to be applied first.