Repository navigation
AttributeError chaining bug #1944 fix - #1945
Merged
Merged
Conversation
Member
|
Thanks, I've seen this happen on occasion but never took the time to properly look it up. Would you mind add a CHANGELOG entry as well? |
Author
|
@nicoddemus done |
Member
|
Thanks! Maybe it'd make sense to include a test which creates a file like the one in the issue, runs pytest over it, and checks that "AttributeError" isn't in the output? Should be really straightforward to add and prevent regressions for this in the future. |
Stranger6667
left a comment
Contributor
There was a problem hiding this comment.
Thank you guys for fixing this issue :)
Author
|
Added a test, rebased against master. |
Member
|
Can you please take a look at the failing builds? |
added 2 commits
September 20, 2016 02:47
Author
|
All passed now. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
master; for new features, targetfeatures;AUTHORS;CHANGELOG.rstCHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.