Skip to content

feat: add a custom 404 page - #2165

Merged
henryiii merged 2 commits into
pypa:mainfrom
henryiii:henryiii/feat/404
Oct 26, 2026
Merged

henryiii merged 2 commits into
pypa:mainfrom
henryiii:henryiii/feat/404

Conversation

@henryiii

@henryiii henryiii commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

This will make it easier to remove pages; now the 404 page doesn't take you out of the webpage, and it shows a link to the main page.

This should help us remove some of the really old pages that are no longer relevant.

Used AI assistence to debug local preview (mostly required a newer version of sphinx-autobuild and one workaround in conf.py)


📚 Documentation preview 📚: https://python-packaging-user-guide--2165.org.readthedocs.build/en/2165/

This will make it easier to remove pages; now the 404 page doesn't take you out of the webpage, and it shows a link to the main page.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii! Adding the 404 and the text of it LGTM.

The requirements.txt changes look like they will break the translations workflow, which is still on Python 3.10:

Comment thread source/404.rst Resolved
@rgommers rgommers added the type: enhancement A self-contained enhancement or new feature label Oct 26, 2026
Pin sphinx-autobuild to 2024.10.3, since 2025.8.25 needs Python 3.11
and the translation workflow uses Python 3.10.

Assisted-by: ClaudeCode:claude-opus-5-5
@henryiii

Copy link
Copy Markdown
Contributor Author

I went with an older sphinx-autobuild for now to keep 3.10, so that can be its own PR.

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@henryiii
henryiii enabled auto-merge October 26, 2026 22:38
@henryiii
henryiii added this pull request to the merge queue Oct 26, 2026
Merged via the queue into pypa:main with commit 4538176 Oct 26, 2026
7 checks passed
@henryiii
henryiii deleted the henryiii/feat/404 branch October 26, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A self-contained enhancement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants