Repository navigation
Split up wheel building for aarch64 - #93
Conversation
9aa6a91 to
036c04d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
========================================
Coverage 96.89% 96.89%
========================================
Files 2 2
Lines 258 258
Branches 61 61
========================================
Hits 250 250
Misses 4 4
Partials 4 4 Continue to review full report at Codecov.
|
|
@marcelm FYI: I changed the CIBW docker image for linux from manylinux2014 to nothing specified (CIBW default) in this PR. This means the wheels should build on older versions of pip as well from the next release onwards. That should solve a whole category of bugs that was opened on cutadapt/xopen. |
|
Thanks, that is actually something I had wanted to bring up! |
|
I tested it, and it doesn't make any speed difference whether the manylinux1/manylinux2010 wheels are used or the manylinux2014 ones. And since security is not really an issue here (I only use constants and memmove and memcpy from libc) I thought it best to transition. |
| if: "runner.os == 'Linux'" | ||
| run: python setup.py sdist | ||
| if: "runner.os == 'Linux' and ${{ matrix.build_sdist }}" | ||
| run: bash -c 'pip install cython && python setup.py sdist' |
There was a problem hiding this comment.
BTW, the modern way to build an sdist is with build with something like "pip install build && python -m build --sdist"
There was a problem hiding this comment.
Thanks for sharing! That is incorporated now!
Checklist