Skip to content

Split up wheel building for aarch64 - #93

Merged
rhpvorderman merged 5 commits into
developfrom
wheelbuildingimprove
Sep 15, 2021
Merged

rhpvorderman merged 5 commits into
developfrom
wheelbuildingimprove

Conversation

@rhpvorderman

@rhpvorderman rhpvorderman commented Sep 15, 2021 •

Copy link
Copy Markdown
Collaborator

Checklist

  • Pull request details were added to CHANGELOG.rst
  • Documentation was updated (if needed)

@codecov

codecov Bot commented Sep 15, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #93 (21625e7) into develop (7cecc4d) will not change coverage.
The diff coverage is n/a.

❗ Current head 21625e7 differs from pull request most recent head 6d9c7c1. Consider uploading reports for the commit 6d9c7c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #93   +/-   ##
========================================
  Coverage    96.89%   96.89%           
========================================
  Files            2        2           
  Lines          258      258           
  Branches        61       61           
========================================
  Hits           250      250           
  Misses           4        4           
  Partials         4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cecc4d...6d9c7c1. Read the comment docs.

@rhpvorderman

Copy link
Copy Markdown
Collaborator Author

@marcelm FYI: I changed the CIBW docker image for linux from manylinux2014 to nothing specified (CIBW default) in this PR. This means the wheels should build on older versions of pip as well from the next release onwards. That should solve a whole category of bugs that was opened on cutadapt/xopen.

@rhpvorderman
rhpvorderman merged commit c0ff4d8 into develop Sep 15, 2021
@rhpvorderman
rhpvorderman deleted the wheelbuildingimprove branch September 15, 2021 14:01
@marcelm

marcelm commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Thanks, that is actually something I had wanted to bring up!

@rhpvorderman

Copy link
Copy Markdown
Collaborator Author

I tested it, and it doesn't make any speed difference whether the manylinux1/manylinux2010 wheels are used or the manylinux2014 ones. And since security is not really an issue here (I only use constants and memmove and memcpy from libc) I thought it best to transition.

Comment thread .github/workflows/ci.yml
if: "runner.os == 'Linux'"
run: python setup.py sdist
if: "runner.os == 'Linux' and ${{ matrix.build_sdist }}"
run: bash -c 'pip install cython && python setup.py sdist'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the modern way to build an sdist is with build with something like "pip install build && python -m build --sdist"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing! That is incorporated now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants