Skip to content

Missing wheels for Windows on 1.9.0 #313

Closed

Description

@ThermodynamicBeta

Hi, version 1.8.0 had prebuilt wheels for Windows which allowed this (and asammdf) to be built without a C compiler. 1.9.0 doesn't have this anymore. Will it be added?

Activity

  1. rhpvorderman commented on Nov 3, 2026

    @rhpvorderman
    Collaborator

    This is due to the build and upload process failing on macos and cancelling the other processes. I am currently separating the build and upload process.

    These shennanigans keep happening everytime I release. I release not very often and somehow the chair is always pulled from under me when I do. The build and upload process I used last time somehow does not work for some obscure reason.

    Having separated out the build and upload process this should go a bit better in the future.

    All wheels will be uploaded when I manage to fix it.

  2. ThermodynamicBeta commented on Nov 3, 2026

    @ThermodynamicBeta
    Author

    Thank you! @rhpvorderman . Will you make the release contingent on all the builds succeeding?

  3. rhpvorderman commented on Nov 4, 2026

    @rhpvorderman
    Collaborator

    Yes. The resulting builds will be pushed to the artifact store. Afterwards a separate release process downloads the builds from the artifact store and pushes to PyPI.
    This has the advantage that I can manually download from the artifact store and upload manually, in case this is needed. Also PyPI has a new process that allows repos to publish directly to PyPI without tokens and with provenance information, so that is now implemented.

    Unfortunately this meant that the 1.9.0 consisted of half non-provenance builts and the other half with provenance. This would be okay if PyPI didn't fly a GIANT RED BANNER with the text "OMG THIS RELEASE IS COMPRIMISED 1!!!11!!1!1! OMG FOR RLZ" above the PyPI entry. Okay, it is not as bad as I made it out to be, the red banner is visible here: https://pypi.org/project/isal/1.9.0/. If you click on "view details" it says: "We recommend further investigation before installing files from this release. Learn more." But who is going to install files after that?

    So I fixed a small bug that a user noticed on python-zlib-ng and released 1.9.1. Now everything should be okay.

  4. ThermodynamicBeta commented on Nov 4, 2026

    @ThermodynamicBeta
    Author

    What is the advantage of publishing without a token/provenance? Does that mean anyone can upload to the isal package?

  5. rhpvorderman commented on Nov 6, 2026

    @rhpvorderman
    Collaborator

    Anyone who has the token. But you then don't know which computer it was pushed from.
    The new publishing method allows for publishing directly from GitHub actions with a certainty that it has been published from Github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions