Repository navigation
FRAM-1182 opts08: recipe c75 (gG5 + film-lot blend chart) for MP-1 panels - #74
Merged
Merged
Conversation
opts08 is opts07 plus a film lot code, opts08:0.65:<lot>:<nine color palette>. It runs the opts07 (gG5) command and adds --blend-chart docs/lot_charts/<lot>.json --blend-chart-scale 0.75 from pushd-dither (PR #58). The lot must look like a panel QR film lot (SPR + 3), since it names a chart file. Bumps plugins/pushd-dither to the PR #58 head; rebump to its merge commit before merging this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lt1xKqZBPFkCeVsPVyLSsD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
opts08= recipe c75: deployed gG5 (opts07) plus the frame's film-lot blend chart at 0.75, for MP-1 panels whose faces render yellow/chartreuse.Format:
dither:fs:opts08:0.65:<lot>:<nine color palette as in opts07>, e.g.opts08:0.65:SPR0RU:bk:…:y2:…What it runs: the exact
opts07command plus--blend-chart docs/lot_charts/<lot>.json --blend-chart-scale 0.75.docs/lot_charts/). SPR0RU = MP-1, SPR1BN = DVT.opts07. pushd-web will keep DVT frames onopts07anyway.^SPR[0-9A-Z]{3}$(a panel QR film lot), because it names a file.Evidence: pushd/pushd-dither#58. On ej's blind bench, MP-1 <3 rate went 21% → 0% vs gG5 (5 fixed, 0 caused); with all 6 panels weighted equally, 20% → 6%.
Tests:
options/processing_options_test.go: opts08 parse, trailing option, bad lots rejected, a missing lot rejected.go test ./options/passes (golang:1.22 + libvips);go vetandgo build ./processing/are clean.Before merging:
plugins/pushd-ditherpoints at the [FRAM-555] Mimic Android CenterCrop behavior when dithering with ResizeFill #58 head (e9d2215). Rebump it to [FRAM-555] Mimic Android CenterCrop behavior when dithering with ResizeFill #58's merge commit once that merges.opts08for SPR0RU frames follows.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lt1xKqZBPFkCeVsPVyLSsD