Repository navigation
Use Number instead of Int for read #25
Description
I've made a branch here to show this in a test: https://github.com/matthewleon/purescript-node-buffer/tree/uint32-test
Relevant code:
testUInt32 :: Test
testUInt32 = do
buf <- fromArray [-1, -1, -1, -1]
readVal <- read UInt32LE 0 buf
logShow readVal -- 4294967295
logShow $ readVal - 1 -- -2
-- chaos reigns: try to uncomment the line below
--logShow $ readVal == 4294967295
Purescript Ints really don't play nice with these operations. They probably require something like https://github.com/zaquest/purescript-uint
Activity
hdgarrood commentedon May 3, 2018
Yes, we should have these functions use a
UInttype. I'd rather it be incontribif we're going to depend on it in this library, though.matthewleon commentedon May 3, 2018
Makes sense. I'd be happy to see it make its way into
contrib.hdgarrood commentedon Dec 30, 2018
Come to think of it, we really ought to be using
Numberas the return type ofread, since you canreadaDouble{BE,LE}or aFloat{BE,LE}out of aBuffer, and clearly any integer type is unsuitable for that. UsingNumberas the return type addresses theUInt32issue too. Since these libraries are meant to be low-level bindings, I think the loss of convenience is acceptable.[-]UInt32 operations: chaos reigns[/-][+]Use Number instead of Int for `read`[/+]Use Number for reading and writing, fixes #25
Merge pull request #35 from purescript-node/number-read-write