Repository navigation
Count NaN histogram observations in the +Inf bucket - #1225
Merged
csmarchbanks merged 1 commit intoOct 30, 2026
Merged
Conversation
Signed-off-by: Zhe Chen <zhechen.cs@connect.hku.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Histogram.observe(float('nan'))updates the sum but increments no bucket, so both_countand the+Infbucket omit the observation. Count these observations in the overflow bucket while retaining the NaN sum and leaving finite bucket counts unchanged. This matches the classic-histogram handling described in the Prometheus histogram specification.Added regressions for ordinary histograms and aggregation from two multiprocess metric files. Both fail on the unmodified base.
Validation on macOS / Python 3.12:
tox -e flake8,isort,mypyandgit diff --check: passed.Local HTTP tests used
NO_PROXY=localhost,127.0.0.1,::1to bypass the local proxy; the proxy's HTTP 502 failure also reproduces on the unmodified base.@csmarchbanks