Dependency Cleanup - #4035
Open
brandonschabell wants to merge 1 commit into
Open
Dependency Cleanup#4035brandonschabell wants to merge 1 commit into
brandonschabell wants to merge 1 commit into
Conversation
…nchmarks from package.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The package-content behavior needs a regression test verifying benchmarks are excluded.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes unnecessary runtime dependencies and excludes repository-only benchmarks from distributions.
Changes:
- Uses standard-library
importlib.metadata. - Removes
setuptoolsandimportlib-metadataruntime dependencies. - Limits package discovery to
dashpackages.
| File | Description |
|---|---|
setup.py |
Restricts packaged modules to dash*. |
requirements/install.txt |
Removes redundant dependencies. |
dash/backends/_quart.py |
Uses standard-library package metadata. |
dash/backends/_flask.py |
Uses standard-library package metadata. |
CHANGELOG.md |
Documents dependency removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| author="Chris Parmer", | ||
| author_email="chris@plotly.com", | ||
| packages=find_packages(exclude=["tests*"]), | ||
| packages=find_packages(include=["dash*"]), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes setuptools and importlib-metadata from the install dependencies. Also removes benchmarks from being included in the package.
Contributor Checklist
optionals
CHANGELOG.md