Conversation
Contributor
|
the regression test for this problem should be placed in e2e/ and run via github actions. please inspect the git history how other recently created PRs utlized e2e testing |
Member
|
I'm also interested how we broke this, what's the first bad commit. |
Contributor
Author
|
aivchen
force-pushed
the
2.2.x-baseline-percent
branch
from
October 1, 2026 13:16
e45382a to
f4e2fc8
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The baseline formatters escaped values with
Nette\DI\Helpers::escape(), which doubles a leading@as well as%. Baseline entries are loaded as parameters, and parameters never turn@@back into@- nette/di deprecates the@@escape in config files altogether. ArawMessageof an error starting with@(e.g.@readonly property cannot have a default value.) therefore never matched its error. Only%still needs escaping, so the formatters now share BaselineParameterEscaper, which does just that.Closes #15337