Repository navigation
Fix the replacement for shmget in Windows - #9946
Closed
TysonAndre wants to merge 3 commits into
Closed
TysonAndre wants to merge 3 commits into
TysonAndre wants to merge 3 commits into
Conversation
TysonAndre
force-pushed
the
fix-9944-windows-shm_get
branch
2 times, most recently
from
November 13, 2022 21:51
0ea9e26 to
176c011
Compare
Closes php#9944 https://man7.org/linux/man-pages/man2/shmget.2.html notes The name choice IPC_PRIVATE was perhaps unfortunate, IPC_NEW would more clearly show its function.
TysonAndre
force-pushed
the
fix-9944-windows-shm_get
branch
from
November 13, 2022 22:00
176c011 to
8db6bd5
Compare
TysonAndre
commented
Nov 13, 2022
cmb69
reviewed
Nov 15, 2022
cmb69
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR! The general solution looks good to me, but we likely need to figure out some details.
cmb69
approved these changes
Nov 29, 2022
cmb69
left a comment
Member
There was a problem hiding this comment.
Thank you! I don't see a reasonable way to add a test case (adding something to ext/zend_test appears to be overkill), so this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9944
https://man7.org/linux/man-pages/man2/shmget.2.html notes
The name choice IPC_PRIVATE was perhaps unfortunate, IPC_NEW
would more clearly show its function.