Repository navigation
Conversation
|
The second commit in the PR history changes the context option name to |
|
Travis reports the following failed test: This test has nothing to do with the code involved in this PR and I've been unable to duplicate the failure locally. |
|
I'll check that failing test. Regarding a test for this feature, would it be possible to write a test that uses the openssl CLI? |
|
@m6w6 Sorry for being off-grid for the last month -- real life intervened. I'll work on getting this tested and locked down for merge. |
|
Closing as this PR is now part of [RFC] Improved TLS Defaults |
Mitigating the BEAST TLS Vulnerability
The BEAST TLS attack vector was first publicized in 2011. Mitigating this attack is relatively simple: servers have only to prioritize ciphers that aren't susceptible to the attack. However, unless instructed otherwise, OpenSSL uses the client's preferences when negotiating the cipher. To prevent nefarious (or naive) clients from prioritizing susceptible ciphers servers must configure SSL sessions using OpenSSL's
SSL_OP_CIPHER_SERVER_PREFERENCEcontext option.Proposed Solution
This patch adds a new boolean ssl context option,
"honor_cipher_order", to mitigate BEAST vulnerabilities in encrypted stream servers.Suggested Usage
How Problematic Is This Really?
-- SSL Labs Best Practices Report (September 2013)
Other Considerations
It's not really possible to include tests for this functionality without adding new functions to retrieve the negotiated cipher from an encrypted socket stream. I don't generally feel like creating functions solely for use in testing things is a good idea, so there are no .phpt tests included. I may PR a new function to get meta information about the SSL session in the future, though. In such a case I'll go ahead and add tests for this scenario.