Repository navigation
Conversation
The compress.zlib:// and compress.bzip2:// wrappers open the path that follows their scheme through the stream layer, so whether such a stream is local depends on the inner wrapper. stream_is_local() and the openssl cafile check treated them as always local. Replace the is_url field with a flags field. PHP_STREAM_WRAPPER_FLAG_URL keeps the value 1 so existing initializers are unchanged, and the new PHP_STREAM_WRAPPER_FLAG_NESTED marks wrappers that open the remainder of the path. php_stream_wrapper_is_url() walks nested schemes in a loop for path strings, and PHP_STREAM_FLAG_URL is set on opened streams, copied from the inner stream by nested wrappers, so php_stream_is_url() needs no lookup. The open path and the allow_url_fopen enforcement at the inner open are unchanged. Co-authored-by: Daniel Scherzer <daniel.e.scherzer+phpf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compress.zlib:// and compress.bzip2:// wrappers open the path that follows their scheme through the stream layer, so whether such a stream is local depends on the inner wrapper. stream_is_local() and the openssl cafile check treated them as always local.
Replace the is_url field with a flags field. PHP_STREAM_WRAPPER_FLAG_URL keeps the value 1 so existing initializers are unchanged, and the new PHP_STREAM_WRAPPER_FLAG_NESTED marks wrappers that open the remainder of the path. php_stream_wrapper_is_url() walks nested schemes in a loop for path strings, and PHP_STREAM_FLAG_URL is set on opened streams, copied from the inner stream by nested wrappers, so php_stream_is_url() needs no lookup. The open path and the allow_url_fopen enforcement at the inner open are unchanged.