Skip to content

#62489: dba_insert not working as expected - #125

Closed
marc-mabe wants to merge 1 commit into
php:masterfrom
marc-mabe:bug62489
Closed

marc-mabe wants to merge 1 commit into
php:masterfrom
marc-mabe:bug62489

Conversation

@marc-mabe

Copy link
Copy Markdown
Contributor

removed warnings if dba_insert failed because of an already existing key.

fixed handlers are:

  • flatfile
  • gdbm
  • inifile
  • qdbm

@smalyshev

Copy link
Copy Markdown
Contributor

Please add a test.

@marc-mabe

Copy link
Copy Markdown
Contributor Author

@smalyshev: Tests added now

The test for the inifile handler fails because this handler insert items even if the item already exists.
I removed the waring "Key already exists" within DBA_UPDATE_FUNC(inifile) but the switch case never occur because inifile_append doesn't implement such functionality.

I'm not a C developer so it would be the best merging this but leaving the bug open so another person can fix it.

@marc-mabe

Copy link
Copy Markdown
Contributor Author

Hello guys, is there someone could review this ?

Comment thread ext/dba/dba_gdbm.c Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting is wrong here.

@lstrojny

lstrojny commented Jan 6, 2013

Copy link
Copy Markdown
Contributor

@marc-mabe sorry for the long delay. Please fix the coding style issues after that it looks good for merge.

@marc-mabe

Copy link
Copy Markdown
Contributor Author

@lstrojny : thank you for review! Updated coding style issues now

Comment thread ext/dba/dba_gdbm.c Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really correct? Shouldn’t be the default case just throw some error?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default case should be impossible - it was copied from DBA_UPDATE_FUNC(flatfile)

  • What should the message say on this case ?
  • "Unknown return value %value% by %lib-function%" ?
  • error, warning or notice?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Unknown return value" is fine. Warning seems appropriate to me.

@lstrojny

Copy link
Copy Markdown
Contributor

After fixing the switch case, could you rebase and squash?

…ected handlers are flatfile, inifile, qdbm and gdbm)
@marc-mabe

Copy link
Copy Markdown
Contributor Author

done! - updated the switch statements and squashed all commits together

Comment thread ext/dba/dba_qdbm.c

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

@lstrojny

Copy link
Copy Markdown
Contributor

Merged into 5.5 and master. Cannot close it now as GitHub seems to be in trouble.

@php-pulls

Copy link
Copy Markdown

Comment on behalf of lstrojny at php.net:

Merged

@php-pulls php-pulls closed this Jan 15, 2013
heyJordanParker referenced this pull request in heyJordanParker/php-sharp Oct 11, 2026
SHARP_MAGO_COMMIT named the head of Mago #125 while it was under review.
#125 merged, so the pin now names its merge commit on Mago master. That
commit also words an Any comparison operand in PHP#'s words in a .sharp
file. The header it generates differs from this one only in the pin.

ext/sharp/
└── sharp_unit.h                             <- SHARP_MAGO_COMMIT pins Mago 449377a, the merge of #125
heyJordanParker referenced this pull request in heyJordanParker/php-sharp Oct 13, 2026
Problem: the generics slice branched from master c3a4a3c. Master since
gained effects on function types (#126), private fields with no modifier
(#128), union collections (#116), the sortedBy key rule (#125), macOS and
Linux CI (#127), function uses (#122) and message fixes (#117). Ten files
conflicted, and one master test named a syntax field the slice renamed.

Solution: every conflict keeps both sides' behavior.
- A refused expression has the error type in PHP# and `never` in PHP, as
  master types it, and `is_refused` keeps the slice's wider set of refused
  generic expressions.
- An argument is a possible mismatch only when the parts it may share with
  the parameter, as `shareable_part` takes them, fit through master's
  `can_argument_be_identical`, and `verify_argument_type` returns whether
  the argument fits, as master's effect rules read it.
- A method value's signature names the class it is read through, as master
  needs for `extern` lookups, while the slice still specializes it for its
  receiver and fixes its type arguments.
- A PHP# literal's backed enum key and master's other new calls pass the
  dialect `get_backing_key_type` takes on the slice.
- Comparisons master added use the slice's `ComparisonResult::for_dialect`.

crates/
├── analyzer/src/
│   ├── artifacts.rs                         tested_types beside function_values
│   ├── expression/
│   │   ├── array.rs                         master's PHP# key branch, with the dialect
│   │   ├── assignment/array_assignment.rs   every declared element, for_dialect
│   │   └── mod.rs                           slice's is_refused, master's error type
│   ├── invocation/arguments.rs              shareable_part over can_argument_be_identical
│   ├── resolver/
│   │   ├── method.rs                        declared collections, paired with their written atomic
│   │   └── property.rs                      method value source is the read-through class
│   └── statement/
│       ├── class_like/property.rs           for_dialect, records fitting function values
│       └── function_like/mod.rs             passes tested_types and function_values up
├── codex/src/scanner/ttype.rs               function type keeps its effects and its type parameters
└── syntax/tests/sharp.rs                    effects test reads type_arguments.arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants