Skip to content

shmop_open should throw ValueError for ids overflowing sizeof int #9945

Closed

Description

@TysonAndre

Description

The following code:

<?php // based on ext/shmop/tests/shmop_open_private.phpt
$write = 'test';

$shm1 = shmop_open(0x2_0000_0001, 'c', 0777, 1024);
shmop_write($shm1, $write, 0);

$shm2 = shmop_open(0x1_0000_0001, 'c', 0777, 1024);
$read = shmop_read($shm2, 0, 4);

var_dump(is_string($read) && $read !== $write);

Resulted in this output:

bool(false)

But I expected this output instead:

bool(true)

(seen on 64-bit linux with sizeof(int) == 4, sizeof(zend_long) == 8)

Not really something users are likely to do deliberately

This also means that 0x1_0000_0000 is an alias for IPC_PRIVATE, which always creates a new memory segment.

Noticed while looking into #9944

PHP Version

Any

Operating System

No response

Activity

  1. cmb69 commented on Nov 14, 2022

    @cmb69
    Member

    Yeah, that behavior is not correct; however, key_t is underspecified by POSIX; it merely mandates that key_t is an arithmetic type, so we probably can't assume it is int everywhere.

  2. TysonAndre commented on Nov 14, 2022

    @TysonAndre
    ContributorAuthor

    Yeah, that behavior is not correct; however, key_t is underspecified by POSIX; it merely mandates that key_t is an arithmetic type, so we probably can't assume it is int everywhere.

    key != (zend_long)(key_t)key should work as a runtime check.

  3. cmb69 commented on Nov 15, 2022

    @cmb69
    Member

    key != (zend_long)(key_t)key should work as a runtime check.

    If key_t is signed and its rank is less than that of zend_long, wouldn't that possibly be undefined behavior.

    Anyhow, shm_attach() has exactly the same issue than shmop_open().

  4. cmb69 commented on Nov 15, 2022

    @cmb69
    Member

    it merely mandates that key_t is an arithmetic type

    This is ugly, since arithmetic types even include float etc. However, we can hopefully assume that it is actually an integer type, and as such could determine the details during configuration: its size (sizeof(key_t), and its signedness.

  5. self-assigned this
    on Jun 23, 2026
  6. added a commit that references this issue on Jun 24, 2026
    270ffa7
  7. added a commit that references this issue on Jun 24, 2026
    34116ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions