You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
zend_signal_handler_defer() called in a thread not managed by PHP on ARM64 ZTS build #9809
I'll try to take a look tomorrow or on Monday. Basically the change prevents the signal handlers to be executed on threads where TSRM hasn't been started (that was causing segmentation faults). We're probably in this case here.
This could happen if the signal is delivered after tsrm_shutdown(). We should move the tsrm_is_managed_thread() check after the tsrm_is_shutdown() one.
Activity
bukka commentedon Oct 22, 2022
I see those too in https://app.travis-ci.com/github/php/php-src/jobs/586399691 . From a quick look it seems to me like it might be due to the way the http server is killed in
http_server_kill:Not sure really why though so this might need some further investigation.
dunglas commentedon Oct 22, 2022
I'll try to take a look tomorrow or on Monday. Basically the change prevents the signal handlers to be executed on threads where TSRM hasn't been started (that was causing segmentation faults). We're probably in this case here.
iluuu1994 commentedon Oct 22, 2022
/cc @arnaud-lb
arnaud-lb commentedon Oct 23, 2022
This could happen if the signal is delivered after
tsrm_shutdown(). We should move thetsrm_is_managed_thread()check after thetsrm_is_shutdown()one.bukka commentedon Oct 23, 2022
Yeah agreed, the
tsrm_is_managed_thread()should not be called after shutdown. The swap committed in 365178ailuuu1994 commentedon Oct 24, 2022
CI looks good now, so I'm assuming this is properly fixed. Thank you!