You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The referenced issue did not intend to bump the minimum version of icu:
... On older versions of ICU, we only allow TYPE_AND and WIDTH_WIDE - we need this because (...) the minimum version ICU supported is 57, which was bumped from 50 last year.
However, with icu 63 it no longer compiles saying: ext/intl/listformatter/listformatter_arginfo.h:41:35: error: ‘ULISTFMT_TYPE_AND’ undeclared (first use in this function); did you mean ‘ULISTFMT_ELEMENT_FIELD’?
icu::ListFormatter is from ICU 50, but the ULISTFMT_TYPE_AND const is indeed from ICU 67 while the intl extension only requires ICU 57.1.
I suppose we can wrap the new class with #if U_ICU_VERSION_MAJOR_NUM >= 67. @BogdanUngureanu feel free to work on it please, otherwise I can pick up later this week too.
Activity
BogdanUngureanu commentedon Jun 16, 2025
Hi Sjon, I'll look into it tonight. :)
Ayesh commentedon Jun 16, 2025
icu::ListFormatteris from ICU 50, but theULISTFMT_TYPE_ANDconst is indeed from ICU 67 while theintlextension only requires ICU 57.1.I suppose we can wrap the new class with
#if U_ICU_VERSION_MAJOR_NUM >= 67. @BogdanUngureanu feel free to work on it please, otherwise I can pick up later this week too.BogdanUngureanu commentedon Jun 16, 2025
@Ayesh I don't think that's necessary; we just need to not use those constants for that ICU target. I'll open a PR ASAP for it. :)