Skip to content

master fails to compile with icu 63 #18860

Closed

Description

@SjonHortensius

Description

I'm looking at SjonHortensius/3v4l_org#41 which fails, probably caused by #18519

The referenced issue did not intend to bump the minimum version of icu:

... On older versions of ICU, we only allow TYPE_AND and WIDTH_WIDE - we need this because (...) the minimum version ICU supported is 57, which was bumped from 50 last year.

However, with icu 63 it no longer compiles saying: ext/intl/listformatter/listformatter_arginfo.h:41:35: error: ‘ULISTFMT_TYPE_AND’ undeclared (first use in this function); did you mean ‘ULISTFMT_ELEMENT_FIELD’?

@BogdanUngureanu

PHP Version

master

Operating System

No response

Activity

  1. BogdanUngureanu commented on Jun 16, 2025

    @BogdanUngureanu
    Contributor

    Hi Sjon, I'll look into it tonight. :)

  2. Ayesh commented on Jun 16, 2025

    @Ayesh
    Member

    icu::ListFormatter is from ICU 50, but the ULISTFMT_TYPE_AND const is indeed from ICU 67 while the intl extension only requires ICU 57.1.

    I suppose we can wrap the new class with #if U_ICU_VERSION_MAJOR_NUM >= 67. @BogdanUngureanu feel free to work on it please, otherwise I can pick up later this week too.

  3. BogdanUngureanu commented on Jun 16, 2025

    @BogdanUngureanu
    Contributor

    @Ayesh I don't think that's necessary; we just need to not use those constants for that ICU target. I'll open a PR ASAP for it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions