Repository navigation
Include ARM64 packages in dllmap and libmap - #64
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
phpsdk_dllmap and phpsdk_libmap only matched x86 and x64 archive names, so ARM64 dependency zips were silently left out of the generated mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpsdk_dllmapandphpsdk_libmapselect dependency archives with the pattern-(v[c|s]\d+)-(x\d\d)\.zip, which matches onlyx86andx64. ARM64 archives such asICU-77.1-1-vs17-arm64.zipare skipped without a warning, so the generated JSON has noarm64entries even though the dependency server now publishesvs17/arm64packages andarm64series.This change matches
x86,x64andarm64, the same architecture list thatConfig::getKnownBranches()andphpsdk_sbomalready use.Reproduce
libfoo-1.0-vs17-x64.zipandlibfoo-1.0-vs17-arm64.zipin one directory, each containingbin/libfoo.dllandlib/libfoo.lib.phpsdk_dllmap <dir>andphpsdk_libmap <dir>.Before:
After:
phpsdk_libmapshows the same difference forlibfoo.lib.Testing
php -lpasses for both files.Fixes #63