Repository navigation
Conversation
- Add .claude/rules/public-api.md: brief rules for mirroring the upstream Rust DataFusion API in the public Java surface (names, trait-to-interface shape, defaults, Java-only additions) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016TrBZwkmnnLujADyqc9nsF
pgwhalen
force-pushed
the
public-api-rule
branch
from
November 2, 2026 12:32
40bd871 to
caaae75
Compare
- Add rule to .claude/rules/public-api.md: data-carrying Rust enums become sealed interfaces with one record per variant; fieldless enums stay Java enums - Plain-data pub-field structs become records; builder-style structs stay final classes with builders - Document #[non_exhaustive] enums so callers add a default case Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016TrBZvtSe6tvVYT6SVyJpo
- Move .claude/rules/public-api.md to core/src/main/java/org/apache/datafusion/AGENTS.md so any agent that honors nested AGENTS.md (Codex, Cursor, Copilot, etc.) picks it up when working in the public API package - Add sibling CLAUDE.md that imports @AGENTS.md for Claude Code - Add Apache license headers so both files pass RAT Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016TrBZvtSe6tvVYT6SVyJpo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
core/src/main/java/org/apache/datafusion/AGENTS.md, agent instructions for keeping the public Java API in line with the upstream Rust DataFusion API. Using a nestedAGENTS.mdmeans any agent that readsAGENTS.md(Codex, Cursor, Copilot, etc.) picks the rules up when it works in the public API package. A siblingCLAUDE.mdimports it (@AGENTS.md) for Claude Code, which doesn't readAGENTS.mditself.defaultmethods.enums; data-carrying Rust enums become asealed interfacewith onerecordper variant. Plain-datapubstructs become records; builder-style structs stay classes with builders.#[non_exhaustive]enums are documented as such.Resulterrors map to the matching uncheckedDataFusionExceptionsubclass.byte[]payloads, boundary codes) in public signatures.Both files carry the Apache license header and pass
apache-rat-plugin:check.🤖 Generated with Claude Code
https://claude.ai/code/session_016TrBZvtSe6tvVYT6SVyJpo