[redhat-chai-bot]

Summary

• Remove FeatureGatePodGroupPreemptionPolicy and its registration.
• Regenerate the feature matrix and twelve feature-set payload manifests.
• Preserve unrelated feature gates and upstream vendored Kubernetes references.

Validation

• Build, focused tests, and full unit tests passed.
• Lint, dependency verification, and feature-promotion verification passed.
• Generation, payload verification, and protobuf verification for all 15 enabled groups passed.
• CRD, type, integration-test, group-version, prerelease-lifecycle, and payload-CRD verification passed.
• Pre-commit review passed; whitespace checks and working tree are clean.

---

AI-generated. Review for accuracy.

@kannon92 requested from Slack

[openshift-ci]

Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

Walkthrough

The change removes PodGroupPreemptionPolicy from the feature-gate registry and feature table. It also removes the gate from the listed Hypershift and SelfManagedHA manifests, including Default, OKD, DevPreviewNoUpgrade, and TechPreviewNoUpgrade configurations.

Priority: Low

Merge Risk: Minimal · up to 32263

No actionable merge-blocking risk was identified in the reviewed change. It is ready to merge after normal checks.

Pre-merge checks: 15

Check name	Status	Explanation
Title check		The title names the primary change: removing the PodGroupPreemptionPolicy feature gate. The raw summary shows the gate is removed from features/features.go, the feature matrix, and the payload-manifes…
Description check		The description states that the FeatureGatePodGroupPreemptionPolicy registration is removed, that the feature matrix and twelve feature-set payload manifests are regenerated, and that unrelated gates …
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names		PASS. The pull request only deletes a feature-gate registration, a feature-matrix row, and manifest entries. It changes no test files and adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality		PASS: The pull request changes only feature-gate declarations, documentation, and payload manifests. The authoritative diff contains no Ginkgo test files, It blocks, resource setup, cleanup, cluster w…
Microshift Test Compatibility		The pull request changes only feature-gate registration, documentation, and YAML manifests. The authoritative diff contains no added Ginkgo tests or test declarations, so the MicroShift test-compatibi…
Single Node Openshift (Sno) Test Compatibility		The pull request adds no tests or Ginkgo constructs. The authoritative diff contains only deletions from the feature matrix, feature-gate registration, and YAML manifests. Therefore, the SNO compatibi…
Topology-Aware Scheduling Compatibility		The check is not triggered. The PR only removes the PodGroupPreemptionPolicy registration, feature-matrix row, and matching entries from feature-gate payload manifests. The diff adds no scheduling c…
Ote Binary Stdout Contract		The pull request changes only feature-gate metadata and removes the FeatureGatePodGroupPreemptionPolicy registration. The authoritative diff contains 14 files and 45 deletions, with no added lines. …
Ipv6 And Disconnected Network Test Compatibility		The pull request adds no Ginkgo e2e tests and introduces no network-related test code. The diff only removes a feature-gate declaration, a feature-matrix row, and feature-gate manifest entries.
No-Weak-Crypto		PASS. The pull request only removes the PodGroupPreemptionPolicy feature-gate declaration, documentation row, and manifest entries. The changed lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, EC…
Container-Privileges		The pull request only deletes feature-gate registrations and manifest entries. It adds no container or Kubernetes privilege settings. No changed file contains the specified privilege controls.
No-Sensitive-Data-In-Logs		The pull request only removes a feature-gate registration and manifest entries. The reviewed diff has 45 deletions and no additions. It introduces no logging and no sensitive data in logs.

Full details: Title check

Explanation

The title names the primary change: removing the PodGroupPreemptionPolicy feature gate. The raw summary shows the gate is removed from features/features.go, the feature matrix, and the payload-manifests featuregates files, so the title matches the changeset.

Full details: Description check

Explanation

The description states that the FeatureGatePodGroupPreemptionPolicy registration is removed, that the feature matrix and twelve feature-set payload manifests are regenerated, and that unrelated gates are preserved. It also lists validation steps. This matches the changeset described in the raw summary.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only feature-gate declarations, documentation, and payload manifests. The authoritative diff contains no Ginkgo test files, It blocks, resource setup, cleanup, cluster waits, or assertions. Therefore, none of the stated test-structure or test-quality failure conditions apply.

Full details: Microshift Test Compatibility

Explanation

The pull request changes only feature-gate registration, documentation, and YAML manifests. The authoritative diff contains no added Ginkgo tests or test declarations, so the MicroShift test-compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request adds no tests or Ginkgo constructs. The authoritative diff contains only deletions from the feature matrix, feature-gate registration, and YAML manifests. Therefore, the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

The check is not triggered. The PR only removes the PodGroupPreemptionPolicy registration, feature-matrix row, and matching entries from feature-gate payload manifests. The diff adds no scheduling constraints, workload deployment changes, operator code, controllers, selectors, affinity, topology spread, replicas, or PDBs.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes only feature-gate metadata and removes the FeatureGatePodGroupPreemptionPolicy registration. The authoritative diff contains 14 files and 45 deletions, with no added lines. It changes no main, init, suite setup, or other process-level stdout behavior, so it cannot introduce non-JSON stdout from an OTE binary.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request only removes the PodGroupPreemptionPolicy feature-gate declaration, documentation row, and manifest entries. The changed lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

[kannon92]

/verified by @kannon92

This is just removing a feature gate that will be removed in 1.38. No verification needed here.

[openshift-ci-robot]

@kannon92: This PR has been marked as verified by @kannon92.

Details

In response to this:

/verified by @kannon92

This is just removing a feature gate that will be removed in 1.38. No verification needed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sairameshv]

/lgtm

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

/retitle NO-JIRA: Remove PodGroupPreemptionPolicy feature gate

[openshift-ci-robot]

@redhat-chai-bot: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Remove FeatureGatePodGroupPreemptionPolicy and its registration.
• Regenerate the feature matrix and twelve feature-set payload manifests.
• Preserve unrelated feature gates and upstream vendored Kubernetes references.

Validation

• Build, focused tests, and full unit tests passed.
• Lint, dependency verification, and feature-promotion verification passed.
• Generation, payload verification, and protobuf verification for all 15 enabled groups passed.
• CRD, type, integration-test, group-version, prerelease-lifecycle, and payload-CRD verification passed.
• Pre-commit review passed; whitespace checks and working tree are clean.

---

AI-generated. Review for accuracy.

@kannon92 requested from Slack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kannon92]

/pipeline required

[redhat-chai-bot]

Chai test selection for 322633759649469d4af0b9b954ce0737c97ceb7d → master

• pull-ci-openshift-api-master-e2e-aws-ovn
• pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
• pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
• pull-ci-openshift-api-master-e2e-upgrade

Reason: PR #3142 removes the FeatureGatePodGroupPreemptionPolicy feature gate registration and its entries from all 12 regenerated payload manifests (Default, TechPreview, DevPreview, OKD × SelfManagedHA, Hypershift). Changed surfaces and coverage: 1. e2e-aws-ovn — Default feature set on SelfManagedHA. The gate is removed from Default manifests; verifies cluster installs and runs correctly without the gate listed. 2. e2e-aws-ovn-techpreview — TechPreview feature set. This is the highest-impact axis: the gate was explicitly enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()), so its removal changes TechPreview cluster behavior by reverting the upstream Kubernetes PodGroupPreemptionPolicy scheduler feature to its default state. 3. e2e-aws-ovn-hypershift — Hypershift topology. The Hypershift-specific payload manifests (featureGate-4-10-Hypershift-*.yaml) were all changed; covers Hypershift install and e2e with the gate removed. 4. e2e-upgrade — Upgrade from stable to this PR's payload. Verifies the gate's presence→absence transition during upgrade is handled cleanly by the cluster-version-operator and feature-gate controller. Jobs not selected: - e2e-azure, e2e-gcp: Feature gate removal is cloud-agnostic; AWS coverage is sufficient. - e2e-vsphere-ovn, e2e-vsphere-ovn-techpreview: Changed files do not match the vSphere-specific annotation patterns (which target types_infrastructure.go and vSphere CRD manifests). - e2e-aws-ovn-customnoupgrade: CustomNoUpgrade exercises custom gate overrides, not materially different from Default for a gate removal. Redundant with e2e-aws-ovn. - e2e-aws-ovn-hypershift-conformance: Hypershift topology already covered by e2e-aws-ovn-hypershift. - e2e-aws-serial-*: Parallel e2e jobs provide sufficient scheduler coverage for a gate removal; serial disruption testing adds cost without materially different coverage. - e2e-upgrade-out-of-change, minor-e2e-upgrade-minor: One upgrade job (e2e-upgrade) covers the gate transition path.

/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-techpreview
/test e2e-upgrade

[redhat-chai-bot]

/pipeline mark-pipeline-gate 3226337

[openshift-ci]

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.