Repository navigation
is npm gzip script still useful? #2429
Description
Being that now Cloudflare is used, which means we have Brotli compression available, is the npm gzip script still useful and/or used at all in practice?
Line 11 in 229e9f0
Actually judging from the response headers, it seems Brotli isn't enabled on Cloudflare. Any special reason for not doing this and getting rid of the whole gzip script and serving precompressed files?
Activity
Trott commentedon Aug 17, 2019
@nodejs/build
Trott commentedon Aug 17, 2019
I know most people in build don't deal with the website infra, but I know some of them do. (@rvagg, I think?)
rvagg commentedon Aug 20, 2019
because new shiny things get overlooked
I've turned it on. Give it a test and if it's working then I guess you can remove the "gzip" target. Remember to remove it from the "deploy" target too.
XhmikosR commentedon Aug 20, 2019
Looks good so far, not a huge gain but I guess that's normal since you were using gzip level 9 before. The diff is 1.29KB.
I'd say someone monitors how things will go on the server side with load etc, since files aren't cache-busted and I don't know what the cache ratio is. If all is well, we drop the script and leave Brotli on.