Repository navigation
test: fix test-debug-signal-cluster.js flakyness - #8568
misterdjules wants to merge 3 commits into
Conversation
Do not assume any order and buffering/atomicity of output from child processes' debugger agents. Fixes nodejs#3796.
nodejs-github-bot
added
the
test
| }); | ||
|
|
||
| assert.deepStrictEqual(outputLines, expectedLines); | ||
| assert.equal(expectedContent, ''); |
There was a problem hiding this comment.
Nit: assert.strictEqual() (not necessary, just a preference, hence the Nit, ignore if you have strong contrary feelings)
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI and stress tests come up clean
| // output may be interleaved arbitrarily. Moreover, child processes' output | ||
| // may be written using an arbitrary number of system calls, and no assumption | ||
| // on buffering or atomicity of output should be made. Thus, we process the | ||
| // output of all chid processes' debugger agents character by character, and |
imyller
left a comment
imyller
left a comment
There was a problem hiding this comment.
LGTM pending CI and stress test
|
Rerunning tests on FreeBSD since tests failed to start on that platform during the previous CI tests run. |
|
Updated PR according to code reviews with one separate commit: I'll squash all commits in this PR into one when/if it lands. Tests on FreeBSD all passed, still waiting for stress tests to complete. |
imyller
left a comment
imyller
left a comment
There was a problem hiding this comment.
LGTM with changes and green CI
|
Pushed another commit that actually removes the test from the list of flaky tests. My apologies for omitting that from the first commit. We shouldn't need to rerun CI tests though, as they all turned green and we're running specific stress tests on the two platforms for which we're changing the flaky tests list. |
|
Agreed. CI clean (with usual unrelated failures) and stress test looks very promising |
|
Stress tests all passed, will land asap. |
|
Does not land cleanly on v6, attempting to patch maked the tests fail. |
7 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Tests.
Description of change
Do not assume any order and buffering/atomicity of output from child
processes' debugger agents.
Fixes #3796.