Repository navigation
Conversation
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching.
Member
Author
|
@jasnell as requested in previous PR. |
Contributor
|
Can you add the links in the footer instead? An example would be https://github.com/nodejs/node/pull/7071/files#diff-acabf706a8aa070a8796e3573f7e4678R1561 Otherwise LGTM |
Member
|
nice work, lgtm, that apple url tho .. |
Contributor
|
@rvagg Too short? |
Member
|
@mscdex yeah, that, obviously, I was also wondering how stable the named anchors are |
Contributor
|
I'd suggest using http://illumos.org/man/port_create as the link for event ports. |
Member
Author
|
@eljefedelrodeodeljefe did you get the wrong link for the example ? |
Member
Author
|
Figured it out. Good to learn how to put links at the bottom. Pushed update. |
Contributor
|
👍 |
mhdawson
added a commit
that referenced
this pull request
Jun 2, 2016
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching. PR-URL: #7071 Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Member
Author
|
landed as 138c7af |
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching. PR-URL: #7071 Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
fs
Description of change
As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.
Note I did not find a good link for "event ports" on Solaris. Hoping @davepacheco might be able to suggest one.