Skip to content

crypto: remove the FIPS provider name check - #67358

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:crypto-fips-properties
Open

panva wants to merge 1 commit into
nodejs:mainfrom
panva:crypto-fips-properties

Conversation

@panva

@panva panva commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

FIPS-capable providers can use names other than "fips". Remove the named-provider lookup and explicit self-test from the startup flags, leaving algorithm availability checks to each operation.

Refs: #64979 (comment)

FIPS-capable providers can use names other than fips. Remove the
named-provider lookup and explicit self-test from the startup flags,
leaving algorithm availability checks to each operation.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@panva
panva requested a review from richardlau November 9, 2026 10:49
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 9, 2026
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 9, 2026
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.73%. Comparing base (f344e7f) to head (65551f5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67358   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         798      798           
  Lines      279993   279989    -4     
  Branches    53866    53849   -17     
=======================================
+ Hits       254047   254058   +11     
- Misses      16229    16235    +6     
+ Partials     9717     9696   -21     
Files with missing lines Coverage Δ
src/crypto/crypto_util.cc 56.73% <ø> (+3.14%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 9, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue PRs queued for automated landing through the Commit Queue. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants