Repository navigation
src: wake pending web locks when workers exit - #67305
Open
fatihguzeldev wants to merge 1 commit into
Open
fatihguzeldev wants to merge 1 commit into
fatihguzeldev wants to merge 1 commit into
Conversation
wake requests left pending after worker cleanup. register granted locks under the queue mutex to prevent concurrent exclusive grants, and keep target environments alive until wakeups are queued. add regression tests for worker exits and exclusive lock ownership. Fixes: nodejs#67216 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67305 +/- ##
==========================================
- Coverage 90.69% 90.67% -0.02%
==========================================
Files 797 797
Lines 279612 279622 +10
Branches 53789 53787 -2
==========================================
- Hits 253584 253555 -29
- Misses 16298 16341 +43
+ Partials 9730 9726 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a worker exits, its locks are removed but other requests can stay
pending until another lock request processes the queue.
wake remaining waiters during cleanup. reserve granted locks under the
queue mutex to prevent concurrent exclusive grants, and protect target
environments while queuing wakeups.
Fixes: #67216