Repository navigation
src: check mtime seconds for file-backed blobs - #67302
Open
fatihguzeldev wants to merge 1 commit into
Open
fatihguzeldev wants to merge 1 commit into
fatihguzeldev wants to merge 1 commit into
Conversation
compare the seconds part of mtime as well as nanoseconds. otherwise, same-size edits can go unnoticed on filesystems with coarse timestamps. add regression coverage for both file-backed blob apis. Fixes: nodejs#67283 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67302 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 797 797
Lines 279607 279612 +5
Branches 53782 53790 +8
=======================================
+ Hits 253526 253545 +19
+ Misses 16359 16357 -2
+ Partials 9722 9710 -12
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same-size edits can go undetected because file-backed blobs only check
the nanosecond part of mtime. this checks the seconds part too and adds
regression coverage for both file-backed blob apis.
Fixes: #67283