Repository navigation
Conversation
Avoid a primordial push call for each dependent signal. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67299 +/- ##
==========================================
- Coverage 93.00% 90.68% -2.33%
==========================================
Files 428 797 +369
Lines 195814 279609 +83795
Branches 30287 53780 +23493
==========================================
+ Hits 182117 253557 +71440
- Misses 13371 16347 +2976
- Partials 326 9705 +9379
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use indexed writes instead of primordial push calls when collecting dependent signals to abort.
Abort-throughput benchmarks on Apple M2/macOS 15.7.4, using rebuilt Node v28.0.0-pre binaries against 47438d9. Fixtures were created outside timing, with 30 samples per binary:
Validation:
make -j8: passedmake lint-js: passedpython3 tools/test.py parallel/test-abortsignal-any.mjs parallel/test-abortsignal-drop-settled-signals.mjs: passedmake -j4 test: not run