Repository navigation
Conversation
Some test cases made a single change right after creating a watcher. On macOS, libuv starts the FSEvents stream asynchronously, so that change could be missed and the test hung until it timed out. Keep making the change until the watcher reports it, as the other cases in the file already do. Refs: nodejs/reliability#1715 Refs: nodejs/reliability#1644 Signed-off-by: inoway46 <inoueyuya416@gmail.com>
nodejs-github-bot
added
needs-ci
inoway46
marked this pull request as ready for review
November 6, 2026 10:37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67298 +/- ##
=======================================
Coverage 90.67% 90.68%
=======================================
Files 797 797
Lines 279607 279607
Branches 53782 53782
=======================================
+ Hits 253526 253553 +27
+ Misses 16359 16340 -19
+ Partials 9722 9714 -8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test cases made a single change right after creating a watcher, and on macOS that change could be missed because libuv starts the FSEvents stream asynchronously. This makes them keep changing the file until the watcher reports it, as the other cases already do.
Before the fix, the test timed out 4/2000 on macOS.
After the fix, it passed 2000/2000: https://github.com/inoway46/node/actions/runs/42192877091
Refs: https://github.com/nodejs/node/actions/runs/42177414954
Refs: nodejs/reliability#1715