[jay23606]

The readFileSync short reads regression test depends on /proc//io, which is not present on some Linux systems. It now skips when /proc/self/io is unavailable.

Verification: git diff --check passed. python tools/test.py --mode=release parallel/test-fs-readfilesync-pipe-short-reads could not run because this checkout has no built Release/node.exe.

Regression test: untested: CONTRIBUTING does not mention tests

Fixes #67241

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

[sxa]

That was quick :-)

Also tagging @christianaurichzm who put the original test in in case he wants to look at this fix.

[christianaurichzm]

LGTM, thanks. /proc/<pid>/io only exists when the kernel is built with CONFIG_TASK_IO_ACCOUNTING, so checking /proc/self/io covers the child as well.

[christianaurichzm]

Nit: with this check the common.isLinux one above is redundant, since /proc/self/io doesn't exist outside Linux. Both could be folded into one by moving the fs require up:

const common = require('../common');
const fs = require('fs');

if (!fs.existsSync('/proc/self/io'))
  common.skip('Paces the writes with /proc/<pid>/io.');

[sxa]

I agree that this would be preferable. if the author of this (who I am inclined to suggest may be an AI bot given that they have sometimes sent hundreds of github events each day) does not respond I will create a new PR with that change.

[MikeMcC399]

Creating a separate PR is probably the cleanest way forward.

The submitter also did not respond to my comments / question and they do appear to be ignoring the rules that ban automated submissions and guidelines that require submissions to be pre-tested.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78834/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (3b209b2) to head (c10bb30).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #67242      +/-   ##
==========================================
+ Coverage   90.68%   90.69%   +0.01%     
==========================================
  Files         797      797              
  Lines      279367   279611     +244     
  Branches    53737    53784      +47     
==========================================
+ Hits       253344   253602     +258     
+ Misses      16319    16300      -19     
- Partials     9704     9709       +5     

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MikeMcC399]

@jay23606

Verification: git diff --check passed. python tools/test.py --mode=release parallel/test-fs-readfilesync-pipe-short-reads could not run because this checkout has no built Release/node.exe.

Regression test: untested: CONTRIBUTING does not mention tests

Since you're a first-time contributor you may have missed the information in the Pull Request template:

For code changes:

1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Also, Pull requests > Step 6: Test

Before submitting your changes in a pull request, always run the full Node.js test suite.

with further details under BUILDING > Running tests.

Do you have a Linux/riscv64 system available that you can test on?

[sxa]

Do you have a Linux/riscv64 system available that you can test on?

I've already ran the whole test suite on Linux/riscv64 from this PR and it works as it should :-)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78859/

[MikeMcC399]

@sxa - I overlooked that Jenkins needs a new approval before it will run via request-ci, so I'll hand it back to you!