Skip to content

build: refresh markdown lint dependencies on lockfile changes - #67185

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:refresh-markdown-lint-dependencies
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:refresh-markdown-lint-dependencies

Conversation

@inoway46

@inoway46 inoway46 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

make lint-md can keep using outdated dependencies after the lockfile changes. After #67023 added support for alpha versions, my checkout still used the older linter and rejected valid version entries in the API documentation.

Reinstall dependencies when the lockfile changes, recheck all Markdown files with the updated rules, and stop if installation fails.

Verified that dependency updates trigger installation and linting, unchanged runs skip both, and make test-doc passes.

Reinstall markdown lint dependencies when the lockfile changes and
recheck all Markdown files with the updated rules.

Stop on installation failures instead of continuing with unavailable
or stale dependencies.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Nov 1, 2026
@inoway46
inoway46 marked this pull request as ready for review November 1, 2026 12:42
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (bf246cf) to head (5b9d37d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67185   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         797      797           
  Lines      278787   278787           
  Branches    53610    53611    +1     
=======================================
+ Hits       252849   252855    +6     
+ Misses      16310    16297   -13     
- Partials     9628     9635    +7     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants