Repository navigation
Conversation
Use it for the dbName, table, db, source and target options so they all treat a missing or undefined value as the default. Also mark ReadOptionalBool and ReadOptionalString as [[nodiscard]]. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67042 +/- ##
==========================================
- Coverage 92.96% 90.69% -2.28%
==========================================
Files 428 797 +369
Lines 195232 279566 +84334
Branches 30197 53779 +23582
==========================================
+ Hits 181500 253548 +72048
- Misses 13405 16300 +2895
- Partials 327 9718 +9391
🚀 New features to boost your workflow:
|
trivikr
reviewed
Nov 6, 2026
trivikr
left a comment
trivikr
left a comment
Member
There was a problem hiding this comment.
LGTM overall. Requested two nits.
Remove table_string and target_string, which are no longer used. Add tests that an undefined dbName, table, db, source or target option falls back to the default. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> Assisted-by: Claude Code
trivikr
added
the
request-ci
trivikr
approved these changes
Nov 6, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dedupes string option parsing for
dbName,table,db,sourceandtarget. A missing orundefinedoption now means the default everywhere.Behavior change in
createSession(): it usedHasOwnProperty, so{ table: undefined }and{ db: undefined }threw, andtable/dbinherited from the prototype were ignored. Nowundefinedmeans the default and inherited properties are read, matchingdeserialize()andbackup().Also marks
ReadOptionalBoolandReadOptionalStringas[[nodiscard]].