Skip to content

[v24.x backport] src: list scripts when --run has no command - #66133

Open
Cherry wants to merge 1 commit into
nodejs:v24.x-stagingfrom
Cherry:backport-64606-to-v24.x
Open

[v24.x backport] src: list scripts when --run has no command#66133
Cherry wants to merge 1 commit into
nodejs:v24.x-stagingfrom
Cherry:backport-64606-to-v24.x

Conversation

@Cherry

@Cherry Cherry commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Backports #64606 to v24.x.

Refs: #64606

Two conflicts were resolved against v24.x-staging:

  • src/node_options.h: main uses the DEFINE_BOOL_FIELD macro for these fields; v24.x still uses plain bool, so the new field is declared as bool has_run = false;.
  • doc/node.1: dropped. The man page on v24.x has no --run entry to extend (the doc-kit regeneration of node.1 was never backported), and the same documentation lands via doc/api/cli.md.

Everything else applied cleanly. Verified with a Windows x64 clang-cl release build; parallel/test-node-run and message/node_run_list pass.

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/startup

@Cherry Cherry mentioned this pull request Sep 19, 2026
Merged
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Sep 19, 2026
@codecov

codecov Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (9e39360) to head (0588674).
⚠️ Report is 586 commits behind head on v24.x-staging.

Files with missing lines Patch % Lines
src/node_options-inl.h 50.00% 0 Missing and 3 partials ⚠️
src/node_task_runner.cc 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           v24.x-staging   #66133      +/-   ##
=================================================
- Coverage          90.31%   90.29%   -0.02%     
=================================================
  Files                711      718       +7     
  Lines             228425   238020    +9595     
  Branches           43160    45244    +2084     
=================================================
+ Hits              206293   214926    +8633     
- Misses             14090    14614     +524     
- Partials            8042     8480     +438
Files with missing lines Coverage Δ
src/node.cc 73.84% <100.00%> (-0.65%) ⬇️
src/node_options.h 97.47% <100.00%> (-0.46%) ⬇️
src/node_task_runner.cc 89.78% <95.23%> (+0.45%) ⬆️
src/node_options-inl.h 83.51% <50.00%> (-0.19%) ⬇️

... and 250 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Cherry
Cherry force-pushed the backport-64606-to-v24.x branch from 6217cf8 to 54b428f Compare September 24, 2026 13:22
@Cherry

Cherry commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Looks like the CI failures were upstream. I've rebased and it's looking good now.

@Cherry
src: list scripts when --run has no command
0588674 
Signed-off-by: James Ross <james@jross.me>
PR-URL: nodejs#64606
Fixes: nodejs#64870
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Cherry
Cherry force-pushed the backport-64606-to-v24.x branch from 54b428f to 0588674 Compare September 26, 2026 14:51
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78210/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78218/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78231/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cherry @nodejs-github-bot @aduh95