Skip to content
Navigation Menu
Sign in
Products
Platform
GitHub
Repository hosting, code review, and collaboration
Copilot
AI coding agent for tasks, projects and automated work
Build & Ship
Actions
CI/CD and automation
Code Quality
Quality analysis, fixes, and enforcement
Codespaces
Cloud development environments
Secure
Code Security
Vulnerability detection and remediation
Secret Protection
Secret scanning and leak prevention
All Features
Developers
Learn
Documentation
Training
Certifications
Build
Build with Copilot
Customize Copilot
Integrations
Explore
Trending repos
GitHub Sponsors
Events
Changelog
Changelog
Your source for the latest features, improvements, and fixes across GitHub products, all in one place.
Businesses
By Stage
Enterprises
Team
Startups
Nonprofits
By Industry
Healthcare
Financial services
Manufacturing
Government
See all industries
Evaluate GitHub
Why GitHub
Customer Stories
Business insights
Trust Center
Add-ons
GitHub Advanced Security
Enterprise-grade code security
Copilot for business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Resources
Learn & Connect
Documentation
Resource center
Blog
Events & webinars
Community Forum
Customer Stories
Integrations
Support
Customer support
Training
GitHub Status
Company
About
Partners
Changelog
GitHub Universe
GitHub Universe
The event for developers, by developers — talks, workshops, and what’s next for GitHub.
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
nodejs
node
Repository navigation
Code
Issues
627
(627)
Pull requests
665
(665)
Actions
Projects
Security and quality
Insights
More
items
net: refactor Server.prototype.listen
- #4039
#4039
Closed
jscissr
wants to merge 15 commits into
nodejs:master
nodejs/node:master
from
jscissr:simpler-listen
jscissr/node:simpler-listen
Copy head branch name to clipboard
Conversation
Commits
15
(15)
Checks
Files changed
Closed
net: refactor Server.prototype.listen
#4039
jscissr
wants to merge 15 commits into
nodejs:master
nodejs/node:master
from
jscissr:simpler-listen
jscissr/node:simpler-listen
Copy head branch name to clipboard
Commits
Commits on Aug 13, 2016
Move listenAfterLookup out of listen
Show description for d5452a6
jscissr
committed
d5452a6
View commit details
Copy full SHA for d5452a6
Browse repository at this point
Use normalizeConnectArgs in listen
Show description for 88c44c1
jscissr
committed
88c44c1
View commit details
Copy full SHA for 88c44c1
Browse repository at this point
Replace h with options
jscissr
committed
df8d8c8
View commit details
Copy full SHA for df8d8c8
Browse repository at this point
Only deal with options object
Show description for 959582c
jscissr
committed
959582c
View commit details
Copy full SHA for 959582c
Browse repository at this point
Fix linter errors
jscissr
committed
d1c6f7b
View commit details
Copy full SHA for d1c6f7b
Browse repository at this point
Test the new behavior
jscissr
committed
708e1b4
View commit details
Copy full SHA for 708e1b4
Browse repository at this point
Commits on Aug 15, 2016
Use argument.length directly
Show description for 150723d
jscissr
committed
150723d
View commit details
Copy full SHA for 150723d
Browse repository at this point
Commits on Aug 16, 2016
Rename normalizeConnectArgs to normalizeArgs
jscissr
committed
5ab4028
View commit details
Copy full SHA for 5ab4028
Browse repository at this point
Use string interpolation
jscissr
committed
0bffc03
View commit details
Copy full SHA for 0bffc03
Browse repository at this point
Style: Use brackets around if
jscissr
committed
db798ea
View commit details
Copy full SHA for db798ea
Browse repository at this point
Test: Just use '0' for the port
jscissr
committed
e772fa3
View commit details
Copy full SHA for e772fa3
Browse repository at this point
Optimize argument handling
jscissr
committed
3fb1435
View commit details
Copy full SHA for 3fb1435
Browse repository at this point
Update normalizeArgs comment
jscissr
committed
4a65449
View commit details
Copy full SHA for 4a65449
Browse repository at this point
Commits on Aug 18, 2016
Or expression instead of `if`
jscissr
committed
3848eae
View commit details
Copy full SHA for 3848eae
Browse repository at this point
Commits on Sep 9, 2016
length checking before array access
Show description for 4bb5770
jscissr
committed
4bb5770
View commit details
Copy full SHA for 4bb5770
Browse repository at this point
You can’t perform that action at this time.