Skip to content

src: use smart pointers in cares_wrap.cc - #23813

Closed
danbev wants to merge 6 commits into
nodejs:masterfrom
danbev:cares_smart_pointers
Closed

src: use smart pointers in cares_wrap.cc#23813
danbev wants to merge 6 commits into
nodejs:masterfrom
danbev:cares_smart_pointers

Conversation

@danbev

@danbev danbev commented Oct 22, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
+2 more reviewers
@refack refack refack approved these changes
@mihalskiy mihalskiy mihalskiy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@danbev @nodejs-github-bot @refack @bnoordhuis @jasnell @addaleax @mihalskiy @targos