Skip to content

testbot - #21236

Closed
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-bot-3
Closed

testbot#21236
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-bot-3

Conversation

@maclover7

@maclover7 maclover7 commented Jun 9, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2018

Copy link
Copy Markdown
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/26/pipeline

@maclover7
maclover7 requested a review from a team as a code owner June 9, 2018 20:20
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jun 9, 2018
@maclover7 maclover7 mentioned this pull request Jun 9, 2018
Merged
@maclover7 maclover7 closed this Jun 9, 2018
@maclover7
maclover7 deleted the jm-bot-3 branch June 9, 2018 20:29
@phillipj

phillipj commented Jun 9, 2018

Copy link
Copy Markdown
Member

Looks great, good job @maclover7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maclover7 @nodejs-github-bot @phillipj