Repository navigation
socket name of unix domain sockets #954
Description
It is currently impossible to get the path of a connected unix domain socket. socket.address() returns an empty object if it's not connected over AFINET.
I've looked at lib/net.js, src/tcp_wrap.cc, src/pipe_wrap.cc and libuv and it looks like libuv has support for returning the name of the socket and it is only pipe_wrap.cc that misses something like GetPeerName (I'm not a C coder so I might be wrong on this).
(also filed at nodejs/node-v0.x-archive#9120 a while ago)
Activity
lib,src: add unix socket getsockname/getpeername
timkuijsten commentedon Apr 10, 2015
Wow, until now I didn't know this issue was being worked on and solved. Great work and an example of how active this community is compared with joyent/node where this issue is still untouched.
brendanashworth commentedon Jul 4, 2015
Should this be reopened because the patch hasn't landed yet?
silverwind commentedon Jul 5, 2015
Yeah I think so, sorry for prematurely closing this. PR is here: #956
brendanashworth commentedon Jul 5, 2015
No problem, the patch almost went in before it was deemed semver-major anyways.
lib,src: add unix socket getsockname/getpeername
bnoordhuis commentedon Aug 27, 2015
Fixed by f337595.
bnoordhuis commentedon Aug 27, 2015
Reverted in de88255, reopening.
bnoordhuis commentedon May 11, 2017
Closing, see #12907 - the current behavior of returning a string has been documented.