Skip to content

V8 nightly tests failing, svn no longer supported #9222

Closed
Closed
V8 nightly tests failing, svn no longer supported#9222
Assignees
mhdawson
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.testIssues and PRs related to Node.js core tests and test infrastructure.v8 engineIssues and PRs related to the V8 dependency.

Description

@mhdawson
mhdawson
opened on Oct 21, 2016
  • Version: master
  • Platform: all
  • Subsystem: v8

The v8 test jobs started failing yesterday (the previous nightly run was ok).

See this as an example: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcle-ubuntu1404,v8test=v8test/370/console

On first glance it looks like the url is pointing to the node.js repo instead of the v8 repo

+ make -j 4 v8 DESTCPU=ppc64 ARCH=ppc64.release
tools/make-v8.sh v8
WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://github.com/nodejs/node.git/branches/HEAD/deps/v8" "/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb"' in /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps failed; will retry after a short nap...
WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://github.com/nodejs/node.git/branches/HEAD/deps/v8" "/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb"' in /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps failed; will retry after a short nap...
WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://github.com/nodejs/node.git/branches/HEAD/deps/v8" "/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb"' in /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps failed; will retry after a short nap...
WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://github.com/nodejs/node.git/branches/HEAD/deps/v8" "/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb"' in /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps failed; will retry after a short nap...

v8 (ERROR)

And a specific example:

________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/nodejs/node.git/branches/HEAD/deps/v8 /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb' in '/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps'
[0:00:00] Cloning into '/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/_gclient_v8_bwVGdb'...
[0:00:00] fatal: unable to access 'https://github.com/nodejs/node.git/branches/HEAD/deps/v8/': The requested URL returned error: 410

Activity

  1. mhdawson commented on Oct 21, 2016

    @mhdawson
    mhdawson
    on Oct 21, 2016
    MemberAuthor

    @ofrobots you aware of anything that went in yesterday that might be related ?

  2. mscdex
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    v8 engineIssues and PRs related to the V8 dependency.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 21, 2016

  3. matthewloring commented on Oct 21, 2016

    @matthewloring
    matthewloring
    on Oct 21, 2016

    The builds seem to be failing at the tools/make-v8.sh v8 step. The last few successful runs of the CI printed this message at that step:

    Oh hai! You are using subversion. Chrome infra is eager to get rid of svn support so please switch to git. Tracking bug: http://crbug.com/475320 If you are a project owner, you may request git migration assistance at: https://code.google.com/p/chromium/issues/entry?template=Infra-Git

  4. mhdawson commented on Oct 21, 2016

    @mhdawson
    mhdawson
    on Oct 21, 2016
    MemberAuthor

    I'm traveling to a conference next week so I won't be able to investigate in detail but have asked @jbajwa to take a look.

  5. jbajwa commented on Oct 22, 2016

    @jbajwa
    jbajwa
    on Oct 22, 2016

    google build tool gclient doesn't support SVN anymore, hence we are seeing this error.
    https://chromiumcodereview.appspot.com/2393773003
    Need to update tools/make-v8.sh to use git alternate

  6. jbajwa commented on Oct 24, 2016

    @jbajwa
    jbajwa
    on Oct 24, 2016

    I'm working on this issue. Will update the tools/make-v8.sh script to use the git alternate.

  7. jbajwa commented on Oct 25, 2016

    @jbajwa
    jbajwa
    on Oct 25, 2016

    I updated the script to configure gclient with nodejs/v8.git repository, and performed "gclient sync". As per the documentation here, gclient sync should only pull dependencies mentioned in the DEPS file, but gclient sync seems to be updating the src as well, which is not the intended behaviour. I'm not quite sure how svn was setup before.
    I'm going to request git migration assistance at the link provided in the warning msg before they nuked svn support.

  8. jbajwa commented on Oct 25, 2016

    @jbajwa
    jbajwa
    on Oct 25, 2016

    Hi @s3ththompson,
    I've opened a bug for assistance in migration to git. Could you help on this issue? Thank you.

  9. mhdawson commented on Nov 1, 2016

    @mhdawson
    mhdawson
    on Nov 1, 2016
    MemberAuthor

    @jbajwa any progress on this ?

  10. jbajwa commented on Nov 1, 2016

    @jbajwa
    jbajwa
    on Nov 1, 2016

    @mhdawson
    Hi Michael, I didn't get any update on the bug I opened regarding git migration assistance. I've decided to take another approach where I use gclient fetch to get the latest v8 (+ dependencies) and then do a git cleanup (checkout the files that were modified, and delete unstaged files). I've tested it and its working as expected.
    Pull request #9393

  11. fhinkel commented on Nov 1, 2016

    @fhinkel
    fhinkel
    on Nov 1, 2016
    Contributor

    @jbajwa Sorry for not hearing back on the issue. It's fall vacation time (and a holiday today). I'll ping a few people in the office tomorrow.

  12. mhdawson
    changed the title [-]V8 nightly tests failing, downloads pointing to wrong repo ?[/-] [+]V8 nightly tests failing, svn no longer supported[/+] on Nov 4, 2016
  13. mhdawson
    self-assigned this
    on Nov 10, 2016

  14. mhdawson commented on Nov 10, 2016

    @mhdawson
    mhdawson
    on Nov 10, 2016
    MemberAuthor

    landed #9393 and updated build job. Looks all good now, closing.

  15. mhdawson
    closed this as completedon Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.testIssues and PRs related to Node.js core tests and test infrastructure.v8 engineIssues and PRs related to the V8 dependency.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions