node --inspect fire Runtime.executionContextDestroyed when script finishes executing #7742

Activity

1. nojvek commented on Jul 15, 2016

   

   nojvek

   on Jul 15, 2016

   Last edited by nojvek

   Author

   More actions

   Would the fix be along the lines of:

   
   void AgentImpl::WaitForDisconnect() {
     shutting_down_ = true;
     fprintf(stderr, "Waiting for the debugger to disconnect...\n");
     inspector_->contextDestroyed(inspector_->rootContext);
     inspector_->runMessageLoopOnPause(0);
   }
   

   I could attempt a fix

   /cc @ofrobots
2. mscdex

   added

   inspectorIssues and PRs related to the V8 inspector protocol.Issues and PRs related to the V8 inspector protocol.

   on Jul 15, 2016
3. ofrobots commented on Jul 15, 2016

   

   ofrobots

   on Jul 15, 2016

   Contributor

   More actions

   Sounds good /cc @eugeneo.
4. pavelfeldman commented on Jul 15, 2016

   

   pavelfeldman

   on Jul 15, 2016

   Contributor

   More actions

   Would the fix be along the lines of

   Sort of. It seems you might need to land the plumbing for the contextDestroyed into V8Inspector which is in Blink to achieve that. You can fix it in terms of Node and we'll help with the two-sided commit.

   👍React with 👍1Reacted by Noj Vek
5. nojvek commented on Jul 28, 2016

   

   nojvek

   on Jul 28, 2016

   Last edited by nojvek

   Author

   More actions

   PR #7756
6. eugeneo

   closed this as completedin #12814on May 5, 2017
7. anchnk

   added a commit that references this issue on May 6, 2017

   inspector: report when main context is destroyed

   ...

   8fc7d0b