replServer.setupHistory() silently discards callback errors since v24.2.0

Version

26.0.0-pre

Platform

Linux ubuntu 6.8.0-87-generic #88-Ubuntu SMP PREEMPT_DYNAMIC Sat Oct 11 09:28:41 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Microsoft Windows NT 10.0.26200.0 x64

Subsystem

No response

What steps will reproduce the bug?

Add an intentional bad assert in the file of test case: test\parallel\test-repl-history-perm.js

Run python tools/test.py --mode=release parallel
It reported "All tests passed."

How often does it reproduce? Is there a required condition?

I can reproduce it everytime

What is the expected behavior? Why is that the expected behavior?

Test failed as 1 not equal 2 obviously.

What do you see instead?

[00:51]% 100|+ 3953|- 0]: Done

All tests passed.

Additional information

I try several versions of node. It seemed to happen from v24.2.0.
This is screenshot of v24.1.0

@puskin

The test cases are reachable. The issue is that setupHistory() is not propagating errors thrown within the callback itself, and is just silently discarding them instead, which is a regression from #58225. (cc @puskin)

repl: propagate setupHistory callback errors (fixes nodejs#60837)

@Renegade334

node/lib/internal/repl/history.js

Lines 321 to 327 in b09155d

    
           this[kContext].once('flushHistory', () => { 
        
             if (!this[kContext].closed) { 
        
               this[kContext].resume(); 
        
               onReadyCallback(null, this[kContext]); 
        
             } 
        
           });

I have observed since this is an event listener getting called hence the error propagation were not observed. Updating tests to asynchronous pattern is able to catch these assertion errors.

I have created a PR for this.
@Renegade334 @puskin

test: update multiline REPL navigation tests for error handling

This issue has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

Navigation Menu

Repository navigation

`replServer.setupHistory()` silently discards callback errors since v24.2.0 #60837

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	this[kContext].once('flushHistory', () => {
	if (!this[kContext].closed) {
	this[kContext].resume();
	onReadyCallback(null, this[kContext]);
	}
	});

replServer.setupHistory() silently discards callback errors since v24.2.0 #60837

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

Renegade334 commented on Nov 24, 2025

SudhansuBandha commented on Jun 17, 2026

github-actions commented on Sep 16, 2026

github-actions commented on Oct 17, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`replServer.setupHistory()` silently discards callback errors since v24.2.0 #60837