Repository navigation
Node 24.4.0 OOMs with pnpm #59057
Description
Version
24.4.0
Platform
Any, but primarily seems to happen on Linux.
Subsystem
No response
What steps will reproduce the bug?
See pnpm/pnpm#9743
It appears that something as simply as pnpm install --save @iconify/json using the latest pnpm and node are showing the issue.
Downgrading to Node 24.3 fixes the issue.
How often does it reproduce? Is there a required condition?
All the time.
What is the expected behavior? Why is that the expected behavior?
Not to OOM.
What do you see instead?
OOMs.
Additional information
No response
Activity
Renegade334 commentedon Jul 14, 2025
I'd noticed this as well. Bisects to #58121, likely related to the changes to
Hash::OneShotDigest. The offending call is here.Without testing, I'm fairly certain that the culprit will end up being
node/src/crypto/crypto_hash.cc
Line 278 in 4dafa77
This currently tries to create a Utf8Value from the source data, but before checking whether or not the data is a string, which leads to an attempt to stringify the entire binary. Previously, this initialisation only took place where the input was typechecked.
cc: @nodejs/crypto
fix: build
fix(ci): build failed on Netlify with latest Node.js v24.4.0
fix: build
ci(node-ci) Lock node 24.2 to prevent 24.4 pnpm OOM issue
fix(ci): Node.js 24.4.0 will OOM when used with pnpm, rollback to LTS
typed-sigterm commentedon Jul 18, 2025
Windows here, also encountered this
jasnell commentedon Jul 18, 2025
@Aditi-1400 ... Fyi... I'll take a look this weekend but if you'd like to investigate too, please do :-)
jasnell commentedon Jul 18, 2025
@Renegade334 ... Excellent work narrowing this down.
Aditi-1400 commentedon Jul 18, 2025
@jasnell #59067 seems to fix this :) Thanks @Renegade334!
crypto: avoid copying buffers to UTF-8 strings in `crypto.hash()`
crypto: avoid copying buffers to UTF-8 strings in `crypto.hash()`
prabhu commentedon Jul 24, 2025
Worth getting a CVE since it affects trivial uses of
createHash?Revert back to nodejs
fix(ci): build failed on Netlify with latest Node.js v24.4.0
fix(ci): Node.js 24.4.0 will OOM when used with pnpm, rollback to LTS