Skip to content

test: timers.js fails lint check in master #5823

Closed
Closed
test: timers.js fails lint check in master#5823
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Description

@mhdawson
mhdawson
opened on Mar 21, 2016
  • Version: master
  • Platform: N/A
  • Subsystem: timers:

Started run of jslint on master after seeing error in checking out a PR that did not chagne timers.js at all

https://ci.nodejs.org/job/node-test-linter/1744/

Fails with

+ gmake lint
./node tools/eslint/bin/eslint.js benchmark lib src test tools/doc \
    tools/eslint-rules --rulesdir tools/eslint-rules

/usr/home/iojs/build/workspace/node-test-linter/lib/timers.js
  450:2  error  Unnecessary semicolon  no-extra-semi

Activity

  1. MylesBorins
    added
    timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().
    metaIssues and PRs related to the general management of the project.
    on Mar 21, 2016

  2. MylesBorins commented on Mar 21, 2016

    @MylesBorins
    MylesBorins
    on Mar 21, 2016
    Contributor

    @mhdawson this is definitely broken 😢

    Looks like it happened in this commit 4fe02e2. Switching from a function literal to a function expression removed the need of a semi colon. This specific commit was not put through CI, and thus the lint issue was not found.

    /cc @Fishrock123

  3. mhdawson
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    and removed
    metaIssues and PRs related to the general management of the project.
    timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().
    on Mar 21, 2016

  4. mhdawson commented on Mar 21, 2016

    @mhdawson
    mhdawson
    on Mar 21, 2016
    MemberAuthor

    Will put together a PR to vix

  5. mscdex
    added
    timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().
    on Mar 21, 2016

  6. Fishrock123 commented on Mar 21, 2016

    @Fishrock123
    Fishrock123
    on Mar 21, 2016
    Contributor

    doh

  7. Fishrock123
    closed this as completedin #5825on Mar 21, 2016

  8. Fishrock123 commented on Mar 21, 2016

    @Fishrock123
    Fishrock123
    on Mar 21, 2016
    Contributor

    my bad, fixed in d3a7534

  9. Fishrock123
    added a commit that references this issue on Mar 22, 2016

    timers: fix lint from 4fe02e2

    46f0e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.timersIssues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions