Repository navigation
v0.12.11 cluster-disconnect-race failure on Win7 #5603
Description
The test simple/test-cluster-disconnect-race fails consistently for me on Windows 7.
Test introduced: #5153
Test fixed for windows in V4: Issue = #4450, PR = #4457
Based on that discussion, it looks like the test should be changed to simply skip on Windows. However, copying that fix gives a syntax error
const common = require('../common');
^^^^^
SyntaxError: Use of const in strict mode.
- Version: v0.12.11
- Platform: Windows 7 32 and 64 bit
Test failure:
python tools/test.py --mode=release --progress=tap simple/test-cluster-disconnect-race
1..1
not ok 1 - test-cluster-disconnect-race.js
#events.js:85
# throw er; // Unhandled 'error' event
# ^
#Error: write EPIPE
# at exports._errnoException (util.js:746:11)
# at ChildProcess.target._send (child_process.js:487:28)
# at ChildProcess.target.send (child_process.js:419:12)
# at sendHelper (cluster.js:679:8)
# at send (cluster.js:515:5)
# at Worker.disconnect (cluster.js:422:5)
# at Worker.<anonymous> (C:\gib\code\node_debugging\node\test\simple\test-cluster-disconnect-race.js:22:13)
# at Worker.<anonymous> (C:\gib\code\node_debugging\node\test\common.js:245:15)
# at Worker.emit (events.js:110:17)
# at ChildProcess.emit (events.js:110:17)
---
duration_ms: 0.732
...
Activity
gibfahn commentedon Mar 8, 2016
I also tried adding these lines (from the V4 fix) to the test, but I'm still getting the EPIPE error.
rvagg commentedon Mar 8, 2016
/cc @nodejs/testing
@gibm on v0.12 we don't have a
common.isWindowsso you can simply replace that withprocess.platform === 'win32'. Would you mind submitting a pull request againstv0.12-staging?