Automated ICU update workflow failed #48496

Activity

1. targos

   added

   toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.

   on Jun 19, 2023
2. richardlau commented on Jun 19, 2023

   

   richardlau

   on Jun 19, 2023

   Member

   More actions

   node/tools/dep_updaters/update-icu.sh

   Lines 62 to 64 in 8e710c9

   	sed -i '' -e "s|\"url\": \"\(.*\)\".*|\"url\": \"$NEW_VERSION_TGZ_URL\",|" "$TOOLS_DIR/icu/current_ver.dep"
   	sed -i '' -e "s|\"md5\": \"\(.*\)\".*|\"md5\": \"$CHECKSUM\"|" "$TOOLS_DIR/icu/current_ver.dep"

   I'm guessing this was written on macOS as it's using sed -i '' which won't work in GNU sed -- see https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux/5694430#5694430

   👍React with 👍2Reacted by Luigi Pinca and Antoine du Hamel
3. marco-ippolito commented on Jun 19, 2023

   

   marco-ippolito

   on Jun 19, 2023

   Member

   More actions

   node/tools/dep_updaters/update-icu.sh

   Lines 62 to 64 in 8e710c9

   	sed -i '' -e "s|\"url\": \"\(.*\)\".*|\"url\": \"$NEW_VERSION_TGZ_URL\",|" "$TOOLS_DIR/icu/current_ver.dep"
   	sed -i '' -e "s|\"md5\": \"\(.*\)\".*|\"md5\": \"$CHECKSUM\"|" "$TOOLS_DIR/icu/current_ver.dep"

   I'm guessing this was written on macOS as it's using sed -i '' which won't work in GNU sed -- see https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux/5694430#5694430

   Correct 🙂
4. nodejs-github-bot

   closed this as completedin #48499on Jun 20, 2023
5. nodejs-github-bot

   added a commit that references this issue on Jun 20, 2023

   tools: replace sed with perl

   ...

   e7646a5
6. RafaelGSS

   added a commit that references this issue on Jul 3, 2023

   tools: replace sed with perl

   ...

   4345526
7. Ceres6

   added 2 commits that reference this issue on Aug 14, 2023

   tools: replace sed with perl

   ...

   ebd7318

   tools: replace sed with perl

   ...

   00424af
8. ruyadorno

   added 2 commits that reference this issue on Sep 10, 2023

   tools: replace sed with perl

   ...

   38fb350

   tools: replace sed with perl

   ...

   9711bc2