Repository navigation
[node:test] concurrency type and default value #45643
Description
Affected URL(s)
https://nodejs.org/docs/latest-v18.x/api/test.html
Description of the problem
By https://nodejs.org/docs/latest-v18.x/api/test.html#testname-options-fn we have concurrency field in options which can be number or boolean with defaut value false.
By https://nodejs.org/docs/latest-v18.x/api/test.html#contexttestname-options-fn we have concurrency field in options which can be only number with defaut value 1.
But looks like options should be the same:
https://github.com/nodejs/node/blob/v18.x/lib/internal/test_runner/test.js#L126-L131
By https://nodejs.org/docs/latest-v18.x/api/test.html#runoptions we have concurrency field in options which can be number or boolean with defaut value true.
Should the default value be different from that in test?
Activity
MoLow commentedon Nov 27, 2022
this should accept boolean as well
Semigradsky commentedon Nov 27, 2022
Pay attention to different default values also.
WonJo-Jung commentedon Nov 29, 2022
I'd like to get breakthrough about this issue. @MoLow could you assign this issue to me? :)
WonJo-Jung commentedon Dec 6, 2022
I checked
context.test()andrun()are configuring option values liketest(), except default value ofconcurrencyfield is 1, not false. So I think next step would be revising document about test_runner. Is my suggestion correct? Or other steps remain?MoLow commentedon Feb 6, 2023
fixed by 7d68b7b
MoLow commentedon Feb 6, 2023
thanks @richiemccoll 🎉