Debug build broken on v18.8.0 #44371

Activity

1. VoltrexKeyva

   added

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   on Aug 24, 2022
2. bnoordhuis commented on Aug 24, 2022

   

   bnoordhuis

   on Aug 24, 2022

   Member

   More actions

   Hi Trevor, long time no see! Does it work when you apply this patch?

   diff --git a/src/codegen/register.h b/src/codegen/register.h
   index e36e4d1e9af..36561fe5077 100644
   --- a/deps/v8/src/codegen/register.h
   +++ b/deps/v8/src/codegen/register.h
   @@ -19,18 +19,17 @@ constexpr bool ShouldPadArguments(int argument_count) {
      return ArgumentPaddingSlots(argument_count) != 0;
    }
    
    #ifdef DEBUG
    template <typename... RegTypes,
              // All arguments must be either Register or DoubleRegister.
              typename = typename std::enable_if_t<
                  std::conjunction_v<std::is_same<Register, RegTypes>...> ||
                  std::conjunction_v<std::is_same<DoubleRegister, RegTypes>...>>>
    inline constexpr bool AreAliased(RegTypes... regs) {
   -  int num_different_regs = RegListBase{regs...}.Count();
   +  using FirstRegType = std::tuple_element_t<0, std::tuple<RegTypes...>>;
   +  int num_different_regs = RegListBase<FirstRegType>{regs...}.Count();
      int num_given_regs = (... + (regs.is_valid() ? 1 : 0));
      return num_different_regs < num_given_regs;
    }
    #endif
   
    }  // namespace internal
    }  // namespace v8
3. trevnorris commented on Aug 24, 2022

   

   trevnorris

   on Aug 24, 2022

   ContributorAuthor

   More actions

   Hey Ben! It has been a while. That patch does fix the Debug build issue. Thanks.
4. bnoordhuis

   added a commit that references this issue on Aug 25, 2022

   deps: V8: fix debug build

   ...

   ce33a31
5. trevnorris

   changed the title [-]Debug build broken on v18.8.0-proposal[/-] [+]Debug build broken on v18.8.0[/+] on Aug 26, 2022
6. danielleadams

   added a commit that references this issue on Oct 5, 2022

   deps: V8: fix debug build

   ...

   c892f35
7. github-actions commented on Jun 25, 2026

   

   github-actionsbot

   on Jun 25, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue has been marked as stale due to 210 days of inactivity.
   It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
8. github-actions

   added

   staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

   on Jun 25, 2026
9. github-actions commented on Jul 26, 2026

   

   github-actionsbot

   on Jul 26, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
   If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
10. github-actions

    closed this as not plannedon Jul 26, 2026