Do not send empty TCP packet in _http_outgoing.js #3947

Activity

1. indutny commented on Nov 20, 2015

   

   indutny

   on Nov 20, 2015

   MemberAuthor

   More actions

   See #3803 for reference
2. indutny

   added

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.

   on Nov 20, 2015
3. jasnell commented on Nov 21, 2015

   

   jasnell

   on Nov 21, 2015

   Member

   More actions

   +1 I'd noticed that before too but hadn't managed to get around to fixing it.
   /cc @nodejs/http
4. indutny commented on Nov 21, 2015

   

   indutny

   on Nov 21, 2015

   MemberAuthor

   More actions

   Yeah, it is kind of a way to emit finish event only after completion of all previous writes.
5. trevnorris commented on Nov 23, 2015

   

   trevnorris

   on Nov 23, 2015

   Contributor

   More actions

   Is this a feature request or a bug?
6. indutny commented on Nov 23, 2015

   

   indutny

   on Nov 23, 2015

   MemberAuthor

   More actions

   More like a feature request with the elements of bug fixing.
7. Trott commented on Jun 7, 2016

   

   Trott

   on Jun 7, 2016

   Member

   More actions

   Is there a way to reproduce this not-exactly-a-bug reliably?
8. indutny commented on Jun 8, 2016

   

   indutny

   on Jun 8, 2016

   MemberAuthor

   More actions

   I think yes.
9. Trott commented on Jul 7, 2017

   

   Trott

   on Jul 7, 2017

   Member

   More actions

   Probably don't want to close this, right? But no one's actively working on it either? Is someone available to mentor an interested potential-contributor who might want to try to implement this?
10. bnoordhuis commented on Jul 8, 2017

    

    bnoordhuis

    on Jul 8, 2017

    Member

    More actions

    Has this been fixed? I added a judicious assert (see diff) and I can't reproduce.

    diff --git a/deps/uv/src/unix/stream.c b/deps/uv/src/unix/stream.c
    index 7b23d16..80805e5 100644
    --- a/deps/uv/src/unix/stream.c
    +++ b/deps/uv/src/unix/stream.c
    @@ -1444,6 +1444,7 @@ int uv_write2(uv_write_t* req,
       memcpy(req->bufs, bufs, nbufs * sizeof(bufs[0]));
       req->nbufs = nbufs;
       req->write_index = 0;
    +  assert(0 != uv__count_bufs(bufs, nbufs));
       stream->write_queue_size += uv__count_bufs(bufs, nbufs);
     
       /* Append the request to write_queue. */

    (It does break some REPL and child process tests but that's expected. The salient part is that no zero-sized TCP writes seem to take place.)
11. apapirovski commented on Apr 11, 2018

    

    apapirovski

    on Apr 11, 2018

    Contributor

    More actions

    This seems to be addressed from what I can tell. Please feel free to re-open if you think I'm wrong or this needs to remain open to tackle some edge cases.
12. apapirovski

    closed this as completedon Apr 11, 2018