Repository navigation
How to unref readline? #36154
Description
Activity
Solved via
process.stdin.unref();Reacted by joshxyzhimself, dnlup, Jorge Luis Morales Centeno, Gautam Arora, Chris and Prathamesh AshraAlthough I think it would be nice to add this to docs, so I'll reopen.
- addeddocIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.readlineIssues and PRs related to the built-in readline module.Issues and PRs related to the built-in readline module.
on Nov 19, 2020 @szmarczak I think instead of hanging, the program is waiting for the end of
stdin.
If you start logging what the program reads like the docs say, you will see that it comes to an end after the input is over:const readline = require('readline'); const input = readline.createInterface({ input: process.stdin }); input.on('line', (line) => { console.log(line); })
Here is the log of a run:
❯ time echo 'here is a line'|node index here is a line echo 'here is a line' 0.00s user 0.00s system 33% cpu 0.002 total node index 0.07s user 0.02s system 63% cpu 0.140 total
Reacted by Szymon Marczak@szmarczak if still need to address this issue and add this functionality to the doc I would like to take this and open a PR.
Just want to make sure what is being asked... in this API doc I need to add an example as you described? can you maybe give me any advice about in which section do you think that it would be wise to add this example to?At the end of
readline.createInterface(options)section- added a commit that references this issue
on Dec 9, 2020 I have added the example. Please let me know if it needs an update.
Reacted by Daniel Glazer and Szymon Marczak@aduh95 I see your review on the referenced PR, I can open a new PR addressing your comments there. Can I be assigned to this?
Reacted by Sahdev Zala@AnupamaP By all means, go for it :)
Reacted by Anu Pasumarthy@aduh95 thanks, would appreciate your thoughts on my PR :)
- added a commit that references this issue
on Apr 3, 2021 - added 2 commits that reference this issue
on Apr 4, 2021 - added a commit that references this issue
on May 1, 2021
Is your feature request related to a problem? Please describe.
The code above just hangs.
Describe the solution you'd like
const readline = require('readline'); const input = readline.createInterface({ input: process.stdin }); +input.unref();Describe alternatives you've considered
None yet.